Skip to content

Add support for Organization Discussions #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2023
Merged

Add support for Organization Discussions #158

merged 4 commits into from
Feb 9, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Feb 9, 2023

@fregante fregante added the enhancement New feature or request label Feb 9, 2023
@fregante fregante mentioned this pull request Feb 9, 2023
Merged
@fregante
Copy link
Member Author

fregante commented Feb 9, 2023

I don't know what's up with CI. The install is failing:

Run npm ci || npm install
npm ERR! this.before.toISOString is not a function

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-02-09T12_08_12_046Z-debug-0.log
npm ERR! this.before.toISOString is not a function

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-02-09T12_08_13_095Z-debug-0.log

@fregante fregante merged commit 2bab6f7 into main Feb 9, 2023
@fregante fregante deleted the org-disucsisons branch February 9, 2023 18:46
@fregante
Copy link
Member Author

fregante commented Feb 9, 2023

I think some dependency somewhere is incompatible with Node 18 and it’s failing on CI. I dropped the requirement in the workflow for now, I’ll revisit later.

@fregante
Copy link
Member Author

fregante commented Feb 9, 2023

Thanks to angular/angular-cli#24685 (the only issue on GitHub mentioning that error) I realized that the issue is due to the .npmrc added by #157 😩

fregante added a commit to refined-github/refined-github that referenced this pull request Feb 11, 2023
@fregante
Enable reaction-avatars on organization discussions (#6316)
a25ec23 
- Fixes #5485
- Includes
refined-github/github-url-detection#158




## Org discussions

https://github.com/orgs/community/discussions/11202


<img width="988" alt="Screenshot 1"
src="https://user-images.githubusercontent.com/1402241/217811267-6cc2db97-729c-4447-83ea-c72cae0fd4c3.png">


## Regular discussions


parcel-bundler/parcel#6490

<img width="513" alt="Screenshot 2"
src="https://user-images.githubusercontent.com/1402241/217811411-aa25563d-40cc-4590-a27f-d84596fda3b9.png">

## PRs 

#4119

<img width="617" alt="Screenshot 3"
src="https://user-images.githubusercontent.com/1402241/217811924-80d755e0-301a-46dc-b004-3300f330a4a4.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fregante