chore: upgrade ESLint v6 and related dependencies #3698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
commented
Feb 12, 2020
| rules: { | ||
| 'jsx-a11y/href-no-hash': 'off', | ||
| 'no-unused-vars': 'off', | ||
| '@typescript-eslint/no-unused-expressions': 'off', |
There was a problem hiding this comment.
It looks like this rule is turned on in one of the updated configs, and there are a good number of warnings. Turning off since it's not a style this codebase enforces.
|
Deploy preview for redux-docs ready! Built with commit 49de38d |
kaicataldo
changed the title
|
Thanks! |
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: "\U0001F41B Bug fix or new feature"
about: Fixing a problem with Redux
PR Type
Upgrading dependencies. Apologies if this is the wrong template; it didn't seem like any of them really fit.
Does this PR add a new feature, or fix a bug?
Neither! This upgrades ESLint and the dependencies related to it.
Why should this PR be included?
I'm a maintainer of ESLint and have been working on updating our regression build to ESLint v6. This repo is one we test in our build, and I noticed that this repo is still using ESLint v5. We're currently working on v7, and upgrading it now will help make the next major update smoother :)
Checklist