Fix links to some headings with special chars #3494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of links in tables of contents were broken. These were links where the URL fragment in the target was auto-generated. When that happens, most special characters are removed from the heading. When the links in the tables of contents were written, the ones I am fixing replaced some of the special characters with `-`, instead of stripping them.
|
Deploy preview for redux-docs ready! Built with commit 0679292 |
|
Thanks! |
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
A couple of links in tables of contents were broken. These were links where the URL fragment in the target was auto-generated. When that happens, most special characters are removed from the heading. When the links in the tables of contents were written, the ones I am fixing replaced some of the special characters with `-`, instead of stripping them. Former-commit-id: 04c2939 Former-commit-id: 10f33a2
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
A couple of links in tables of contents were broken. These were links where the URL fragment in the target was auto-generated. When that happens, most special characters are removed from the heading. When the links in the tables of contents were written, the ones I am fixing replaced some of the special characters with `-`, instead of stripping them. Former-commit-id: 04c2939 Former-commit-id: 10f33a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of links in tables of contents were broken.
These were links where the URL fragment in the target was
auto-generated. When that happens, most special characters are removed
from the heading.
When the links in the tables of contents were written, the ones I am
fixing replaced some of the special characters with
-, instead ofstripping them.
I tested the links on my fork on the Performance and React Redux pages.
These screenshots show that the currently live auto-generated URLs
match what I am changing the links to: