Skip to content

Reduce context footprint #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2015
Merged

Reduce context footprint #12

merged 1 commit into from
Jun 3, 2015

Conversation

@ooflorent
Copy link
Contributor

@ooflorent ooflorent commented Jun 3, 2015

Wrapping context would prevent collision with 3rd party libraries.

ooflorent
ooflorent reviewed Jun 3, 2015
View reviewed changes
src/Root.js
Copy link
Contributor Author

@ooflorent ooflorent Jun 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be changed to:

return {
  redux: this.dispatcher
}

gaearon added a commit that referenced this pull request Jun 3, 2015
@gaearon
Merge pull request #12 from ooflorent/wrap-context
61d9fa2 
Reduce context footprint
@gaearon gaearon merged commit 61d9fa2 into reduxjs:master Jun 3, 2015
@gaearon
Copy link
Contributor

gaearon commented Jun 3, 2015

Good point. 👍

@ooflorent ooflorent deleted the wrap-context branch June 3, 2015 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ooflorent @gaearon