Skip to content

Enable lock button for non-Redux connections. #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −5
Open

Enable lock button for non-Redux connections. #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f5a234
Don't disable lock button for non redux connections.
EskiMojo14 May 6, 2024
f019024
remove lock prop from LockButton
EskiMojo14 May 6, 2024
328fe11
add changesets
EskiMojo14 May 7, 2024
136ce3e
format changeset
EskiMojo14 May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-ducks-do.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@redux-devtools/app': minor
---

Enable lock button for non-Redux connections
4 changes: 1 addition & 3 deletions packages/redux-devtools-app/src/components/TopButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ export default class TopButtons extends Component<Props> {
<Toolbar borderPosition="bottom">
{features.pause && <RecordButton paused={isPaused} />}
{features.persist && <PersistButton />}
{features.lock && (
<LockButton locked={isLocked} disabled={options.lib !== 'redux'} />
)}
{features.lock && <LockButton locked={isLocked} />}
<Divider />
<Button
title="Reset to the state you created the store with"
Expand Down
2 changes: 0 additions & 2 deletions packages/redux-devtools-app/src/components/buttons/LockButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { Dispatch } from 'redux';
type DispatchProps = ReturnType<typeof mapDispatchToProps>;
interface OwnProps {
locked: boolean | undefined;
disabled: boolean;
}
type Props = DispatchProps & OwnProps;

Expand All @@ -21,7 +20,6 @@ class LockButton extends Component<Props> {
return (
<Button
tooltipPosition="bottom"
disabled={this.props.disabled}
mark={this.props.locked && 'base0D'}
title={this.props.locked ? 'Unlock changes' : 'Lock changes'}
onClick={this.props.lockChanges}
Expand Down