Skip to content

Conversation

@azizhk
Copy link
Contributor

@azizhk azizhk commented Jul 22, 2017

Fixes #738

Open to Grammar, Capitalization & Style changes. Also can squash, rebase etc.

```

<a id="createProvider"></a>
### `createProvider([storeKey])`
Copy link
Contributor Author

@azizhk azizhk Jul 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to add subKey as well, but then over here:
https://github.com/reactjs/react-redux/blob/a9bb9d3b074eb04f4d7922e22fce733beb148650/src/components/connectAdvanced.js#L78
It is hardcoded to be

const subscriptionKey = storeKey + 'Subscription'

So I don't think I could pass it in connect so it was broken anyways

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should fix that...

@timdorr
Copy link
Member

timdorr commented Jul 22, 2017

LGTM. Thanks!

@timdorr timdorr merged commit 9961062 into reduxjs:master Jul 22, 2017
@azizhk azizhk deleted the patch-1 branch July 22, 2017 17:55
josepot pushed a commit to josepot/react-redux-lean that referenced this pull request Sep 21, 2018
* Add createProvider docs

* Add storeKey to connect options

* italics

* Update api.md

* Add you probably only need this
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
* Add createProvider docs

* Add storeKey to connect options

* italics

* Update api.md

* Add you probably only need this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants