Migrate to React 19 #2172
Closed
Migrate to React 19 #2172
+1,603
−1,860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
aryaemami59
force-pushed
the
migrate-to-react-19
branch
2 times, most recently
from
b7877bc to
93b6f07
Compare
✅ Deploy Preview for react-redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aryaemami59
force-pushed
the
migrate-to-react-19
branch
from
923eff2 to
53261de
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
6 times, most recently
from
1ed9e74 to
ac01df2
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
4 times, most recently
from
67a048a to
258edeb
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
14 times, most recently
from
f219d06 to
5d32aee
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
2 times, most recently
from
054b5fc to
55e7d62
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
from
55e7d62 to
f0063bf
Compare
aryaemami59
force-pushed
the
migrate-to-react-19
branch
from
f0063bf to
a38fd8f
Compare
Closed
3 tasks
14 tasks
|
Merged in #2216 , which is a copy-paste of this PR's commits into a new branch inside this repo. Same work, different PR number! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #2216 (same code, new branch)
This PR:
reactandreact-domto v19.@types/reactand@types/react-domto v19 according to the React 19 migration guide.react-test-rendererpackage as recommended in the React 19 migration guide.@testing-library/reactto latest version.@testing-library/jest-domto latest version.ReactDOM.rendercalls with therenderfunction from@testing-library/reactas recommended in the React 19 migration guide.ReactDOM.unmountComponentAtNodecalls with theunmountfunction from@testing-library/reactas recommended in the React 19 migration guide.renderHookfunction from@testing-library/react-hooksto@testing-library/reactas recommended by A Note about React 18 Support and react-hooks-testing-library React 18 Migration guide.@testing-library/react-hookspackage.renderHookcalls according to react-hooks-testing-library React 18 Migration guide.react-isimplementation.Click to expand
In [PR#28813](https://github.com/Rename the react.element symbol to react.transitional.element facebook/react#28813) `react-is` changed the `REACT_ELEMENT_TYPE` symbol from `'react.element'` to `'react.transitional.element'`. We want our changes to be non-breaking and backwards-compatible so we conditionally set the `REACT_ELEMENT_TYPE` based on the detected version of React. While this is not ideal, the `react-is` package is `CJS` and not very tree-shakable. So for now we want to inline it as to not add unnecessary weight to bundle sizes, not to mention the conditional React version check helps keep our changes backwards-compatible.react-isrelated detailsrtl.cleanupfunction calls insideafterEachhooks as per@testing-library/reactdocs, it is done automatically.reactand@types/reactinpeerDependenciesto include version 19.