Skip to content

Conversation

timdorr
Copy link
Member

@timdorr timdorr commented Sep 30, 2019

Since parseFloat(React.version) resolves to 16.1, that breaks our version check. So, I've switched to checking against the forwardRef API's existence, which was also added in 16.3.

Since `parseFloat(React.version)` resolves to `16.1`, that breaks our version check. So, I've switched to checking against the `forwardRef` API's existence, which was also added in 16.3.
@timdorr timdorr marked this pull request as ready for review September 30, 2019 20:38
Copy link

@samkline samkline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing so quickly!

@samkline
Copy link

Note there are still two deprecated lifecycle methods that are causing warnings, both in src/components/connectAdvanced.js: componentWillUpdate and componentWillReceiveProps.

@timdorr
Copy link
Member Author

timdorr commented Oct 1, 2019

cWRP is deleted and cWU is only in dev mode, so can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants