Skip to content

Conversation

halitogunc
Copy link
Contributor

Some of the links take you to the wrong url which does not exist. This PR fixes it hopefully.

@netlify
Copy link

netlify bot commented Jun 11, 2019

Deploy preview for react-redux-docs ready!

Built with commit 96b817f

https://deploy-preview-1307--react-redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Jun 11, 2019

Thanks!

@timdorr timdorr merged commit 6e1e935 into reduxjs:master Jun 11, 2019
@markerikson
Copy link
Contributor

This seems wrong and hacky to me.

The docs links are supposed to be based on the Markdown file paths, not the final web URL links.

I did note that we had some issues with relative file links when I was fixing up the hooks docs page for final release last night. @endiliey pointed out that Docusaurus really doesn't like relative links - they should be absolute instead.

Can we get another PR that changes all these links to be absolute instead? Like using-react-redux/connect-extracting-data-with-mapStateToProps.md, I think.

@halitogunc
Copy link
Contributor Author

I did not know that Docusaurus has some issues with relative link, but it makes sense to use absolute links instead of relative ones.

I will prepare another PR that applies these changes. @markerikson

@halitogunc
Copy link
Contributor Author

I am a bit confused about that topic. I don't have much experience on Docusaurus but its structure looks so dependent to relative links. Also there is an open issue regarding docs #1001. I might be missing something, need guidance 😄 . On the other hand we can keep the docs as it is and fix it on referenced issue above.

albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants