Added the NUMERIC_IN query clause to manage the Spring-like methods '… #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…In' for Redis repository.
bsbodden
approved these changes
Aug 19, 2025
bsbodden
added a commit
to bsbodden/redis-om-spring
that referenced
this pull request
Aug 19, 2025
…ration - Fix NUMERIC_IN to not escape numeric values (dots in decimals were being escaped) - Add missing NUMERIC_NOT_IN implementation using RediSearch negation pattern - Add support for arrays/varargs parameters in collection queries - Handle empty collections correctly (NUMERIC_IN returns no results, NOT_IN returns all) - Fix query combination for multiple values using proper OR syntax with parentheses test: add comprehensive tests for numeric IN/NOT_IN queries - Add NumericInQueryTest with 17 test cases covering all numeric types - Add NumericIndexedIdFieldTest to verify @NumericIndexed on @id fields - Add NumericInQueryClauseTest for enum verification - Add metamodel generator test for @NumericIndexed ID fields - Test edge cases: empty collections, single values, large numbers, nullables Fixes issues found in PR redis#645 where NUMERIC_IN had syntax errors and NUMERIC_NOT_IN was not implemented. All tests now pass.
bsbodden
added a commit
to bsbodden/redis-om-spring
that referenced
this pull request
Aug 19, 2025
…ration - Fix NUMERIC_IN to not escape numeric values (dots in decimals were being escaped) - Add missing NUMERIC_NOT_IN implementation using RediSearch negation pattern - Add support for arrays/varargs parameters in collection queries - Handle empty collections correctly (NUMERIC_IN returns no results, NOT_IN returns all) - Fix query combination for multiple values using proper OR syntax with parentheses test: add comprehensive tests for numeric IN/NOT_IN queries - Add NumericInQueryTest with 17 test cases covering all numeric types - Add NumericIndexedIdFieldTest to verify @NumericIndexed on @id fields - Add NumericInQueryClauseTest for enum verification - Add metamodel generator test for @NumericIndexed ID fields - Test edge cases: empty collections, single values, large numbers, nullables Fixes issues found in PR redis#645 where NUMERIC_IN had syntax errors and NUMERIC_NOT_IN was not implemented. All tests now pass.
bsbodden
added a commit
that referenced
this pull request
Aug 19, 2025
…ration - Fix NUMERIC_IN to not escape numeric values (dots in decimals were being escaped) - Add missing NUMERIC_NOT_IN implementation using RediSearch negation pattern - Add support for arrays/varargs parameters in collection queries - Handle empty collections correctly (NUMERIC_IN returns no results, NOT_IN returns all) - Fix query combination for multiple values using proper OR syntax with parentheses test: add comprehensive tests for numeric IN/NOT_IN queries - Add NumericInQueryTest with 17 test cases covering all numeric types - Add NumericIndexedIdFieldTest to verify @NumericIndexed on @id fields - Add NumericInQueryClauseTest for enum verification - Add metamodel generator test for @NumericIndexed ID fields - Test edge cases: empty collections, single values, large numbers, nullables Fixes issues found in PR #645 where NUMERIC_IN had syntax errors and NUMERIC_NOT_IN was not implemented. All tests now pass.
bsbodden
added a commit
that referenced
this pull request
Aug 19, 2025
…ration - Fix NUMERIC_IN to not escape numeric values (dots in decimals were being escaped) - Add missing NUMERIC_NOT_IN implementation using RediSearch negation pattern - Add support for arrays/varargs parameters in collection queries - Handle empty collections correctly (NUMERIC_IN returns no results, NOT_IN returns all) - Fix query combination for multiple values using proper OR syntax with parentheses test: add comprehensive tests for numeric IN/NOT_IN queries - Add NumericInQueryTest with 17 test cases covering all numeric types - Add NumericIndexedIdFieldTest to verify @NumericIndexed on @id fields - Add NumericInQueryClauseTest for enum verification - Add metamodel generator test for @NumericIndexed ID fields - Test edge cases: empty collections, single values, large numbers, nullables Fixes issues found in PR #645 where NUMERIC_IN had syntax errors and NUMERIC_NOT_IN was not implemented. All tests now pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
feat(query): add
NUMERIC_INquery clause for Redis repository 'In' methodsfix(indexing): enable
@NumericIndexedtype for@Idfields without schema duplication errorQuery
Introduced support for the
NUMERIC_INquery clause to handle Spring Data style repository methods ending with 'In'.This enables querying Redis repositories using a collection of numeric values, improving parity with Spring Data JPA query method conventions and enhancing developer ergonomics.
Example:
Indexing
Previously, configuring an
@Idfield with the@NumericIndexedindex type was technically possible but caused index creation to fail with:This happened because the Id field was already implicitly added to the index schema, and explicitly declaring it as
@NumericIndexedcreated a duplicate entry.Now, the check also considers
@NumericIndexedin the “already indexed” list, so it won’t add it twice.