fix: add limit support for findTop/findFirst repository methods #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PartTree limit checking in RediSearchQuery.processPartTree() - Methods like findTop2ByOrderByNameAsc now correctly pass limit to Redis - Fixes issue where all methods returned default 10000 results - Add comprehensive tests for various limiting scenarios Fixes redis#630
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where findTop/findFirst repository methods were not properly respecting limit specifications in Redis OM Spring. Previously, methods like findTop2ByOrderByNameAsc would return the default 10,000 results instead of the expected 2 results.
- Added limit checking in
RediSearchQuery.processPartTree()to extract limits from method names - Created comprehensive test coverage for various limiting scenarios (findTop, findFirst, with different numeric limits)
- Added repository interfaces with limiting method definitions for testing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RediSearchQuery.java | Core fix to extract and apply limits from PartTree parsing |
| FindTopLimitingTest.java | Comprehensive test suite for limiting functionality |
| CompanyRepositoryWithLimiting.java | Test repository interface with limiting methods |
| CompanyRepository.java | Added limiting methods to existing repository for testing |
tests/src/test/java/com/redis/om/spring/repository/query/FindTopLimitingTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #630