Skip to content

Add wait metrics to otel #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

Add wait metrics to otel #3493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877f300
Add wait metrics to otel
mwhooker Aug 29, 2025
b964829
add unit
mwhooker Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions extra/redisotel/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,23 @@ func reportPoolStats(rdb *redis.Client, conf *config) (metric.Registration, erro
return nil, err
}

waits, err := conf.meter.Int64ObservableUpDownCounter(
"db.client.connections.waits",
metric.WithDescription("The number of times a connection was waited for"),
)
if err != nil {
return nil, err
}

waitsDuration, err := conf.meter.Int64ObservableUpDownCounter(
"db.client.connections.waits_duration",
metric.WithDescription("The total time spent for waiting a connection in nanoseconds"),
metric.WithUnit("ns"),
)
if err != nil {
return nil, err
}

timeouts, err := conf.meter.Int64ObservableUpDownCounter(
"db.client.connections.timeouts",
metric.WithDescription("The number of connection timeouts that have occurred trying to obtain a connection from the pool"),
Expand Down Expand Up @@ -191,6 +208,9 @@ func reportPoolStats(rdb *redis.Client, conf *config) (metric.Registration, erro
o.ObserveInt64(usage, int64(stats.IdleConns), metric.WithAttributeSet(idleAttrs))
o.ObserveInt64(usage, int64(stats.TotalConns-stats.IdleConns), metric.WithAttributeSet(usedAttrs))

o.ObserveInt64(waits, int64(stats.WaitCount), metric.WithAttributeSet(poolAttrs))
o.ObserveInt64(waitsDuration, stats.WaitDurationNs, metric.WithAttributeSet(poolAttrs))

o.ObserveInt64(timeouts, int64(stats.Timeouts), metric.WithAttributeSet(poolAttrs))
o.ObserveInt64(hits, int64(stats.Hits), metric.WithAttributeSet(poolAttrs))
o.ObserveInt64(misses, int64(stats.Misses), metric.WithAttributeSet(poolAttrs))
Expand Down
Loading