Skip to content

Conversation

ofekshenawa
Copy link
Collaborator

@ofekshenawa ofekshenawa commented Feb 13, 2023

@ofekshenawa ofekshenawa changed the title move from radix v3 to v4 move from radix v3 to v4 and add resp3 support Feb 14, 2023
@filipecosta90 filipecosta90 self-requested a review February 14, 2023 14:58
@filipecosta90 filipecosta90 added the enhancement New feature or request label Feb 14, 2023
@filipecosta90 filipecosta90 changed the title move from radix v3 to v4 and add resp3 support Add RESP3 support Feb 14, 2023
@filipecosta90 filipecosta90 changed the title Add RESP3 support Add RESP3 support ( --resp ) Feb 14, 2023
@filipecosta90 filipecosta90 changed the title Add RESP3 support ( --resp ) Add RESP3 support ( --resp parameter ) Feb 14, 2023
Copy link
Collaborator

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ofekshenawa. approving.
FYI did a quick smoke test to validate the tool is working as expected WRT protocol version:

Used command:

 ./redis-benchmark-go -c 5 -p 6379 -r 1000 -n 100000  --resp 3 --rps 10000  hset __key__ f1 __data__ 
IPs [127.0.0.1]
Total clients: 5. Commands per client: 20000 Total commands: 100000
Using random seed: 12345
Using connection string 127.0.0.1:6379 for client 1
Using connection string 127.0.0.1:6379 for client 2
Using connection string 127.0.0.1:6379 for client 3
Using connection string 127.0.0.1:6379 for client 4
Using connection string 127.0.0.1:6379 for client 5
                 Test time                    Total Commands              Total Errors                      Command Rate           p50 lat. (msec)
                       11s [100.0%]                    100000                         0 [0.0%]                   4654.43                      0.08	
#################################################
Total Duration 11.001 Seconds
Total Errors 0
Throughput summary: 9090 requests per second
Latency summary (msec):
          avg       p50       p95       p99
        0.089     0.083     0.169     0.255

client list output ( notice resp version )

$ redis-cli client list
id=105 addr=127.0.0.1:42840 laddr=127.0.0.1:6379 fd=8 name= age=5 idle=0 flags=N db=0 sub=0 psub=0 ssub=0 multi=-1 qbuf=0 qbuf-free=20474 argv-mem=0 multi-mem=0 rbs=1024 rbp=4 obl=0 oll=0 omem=0 tot-mem=22272 events=r cmd=hset user=default redir=-1 resp=3
id=106 addr=127.0.0.1:42848 laddr=127.0.0.1:6379 fd=9 name= age=4 idle=0 flags=N db=0 sub=0 psub=0 ssub=0 multi=-1 qbuf=0 qbuf-free=20474 argv-mem=0 multi-mem=0 rbs=1024 rbp=4 obl=0 oll=0 omem=0 tot-mem=22272 events=r cmd=hset user=default redir=-1 resp=3
id=107 addr=127.0.0.1:42850 laddr=127.0.0.1:6379 fd=10 name= age=4 idle=0 flags=N db=0 sub=0 psub=0 ssub=0 multi=-1 qbuf=0 qbuf-free=20474 argv-mem=0 multi-mem=0 rbs=1024 rbp=4 obl=0 oll=0 omem=0 tot-mem=22272 events=r cmd=hset user=default redir=-1 resp=3
id=108 addr=127.0.0.1:42866 laddr=127.0.0.1:6379 fd=11 name= age=4 idle=0 flags=N db=0 sub=0 psub=0 ssub=0 multi=-1 qbuf=0 qbuf-free=20474 argv-mem=0 multi-mem=0 rbs=1024 rbp=4 obl=0 oll=0 omem=0 tot-mem=22272 events=r cmd=hset user=default redir=-1 resp=3
id=109 addr=127.0.0.1:42882 laddr=127.0.0.1:6379 fd=12 name= age=4 idle=0 flags=N db=0 sub=0 psub=0 ssub=0 multi=-1 qbuf=0 qbuf-free=20474 argv-mem=0 multi-mem=0 rbs=1024 rbp=4 obl=0 oll=0 omem=0 tot-mem=22272 events=r cmd=hset user=default redir=-1 resp=3
id=110 addr=127.0.0.1:37482 laddr=127.0.0.1:6379 fd=13 name= age=0 idle=0 flags=N db=0 sub=0 psub=0 ssub=0 multi=-1 qbuf=26 qbuf-free=20448 argv-mem=10 multi-mem=0 rbs=16384 rbp=16384 obl=0 oll=0 omem=0 tot-mem=37658 events=r cmd=client|list user=default redir=-1 resp=2

@filipecosta90 filipecosta90 merged commit 74d3b85 into master Feb 14, 2023
@filipecosta90 filipecosta90 deleted the add-resp3-support branch February 14, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add resp3 support to the benchmark tool

2 participants