Skip to content

Added as property to DOM props #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2022
Merged

Added as property to DOM props #603

merged 2 commits into from
Dec 16, 2022

Conversation

@cornedor
Copy link
Contributor

See https://html.spec.whatwg.org/multipage/links.html#link-type-preload for when this can be used. For example:

<link rel="preload" as="style" href="..." />

@peterpme peterpme added the on hold We're interested, but waiting on a feature in Reason, etc. label Jul 16, 2020
@davesnx davesnx removed the on hold We're interested, but waiting on a feature in Reason, etc. label Dec 16, 2022
davesnx
davesnx requested changes Dec 16, 2022
View reviewed changes
Copy link
Member

@davesnx davesnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cornedor, you missed syncing the 2 lists: props and domProps. If you add as_ in props, I will merge this.

Thanks for the contribution!

@cornedor cornedor requested a review from davesnx December 16, 2022 08:01
@cornedor cornedor mentioned this pull request Dec 16, 2022
Merged
@davesnx davesnx merged commit 5a4a87c into reasonml:master Dec 16, 2022
@cornedor cornedor mentioned this pull request Dec 20, 2022
Merged
davesnx pushed a commit that referenced this pull request Dec 20, 2022
@davesnx
Added as property to DOM props (#603)
0aa58fa 
* Added `as` property to DOM props

* Added the as prop to the props type
davesnx added a commit that referenced this pull request Dec 20, 2022
@davesnx
Merge branch 'master' of github.com:/reasonml/reason-react into Upgra…
b6edc08 
…de-bs-platform-to-902

* 'master' of github.com:/reasonml/reason-react:
  Add ocaml lsp editor (#699)
  Add all aria attributes (#697)
  Update Drag.dataTransfer to Js.t (#701)
  Add drag event API binding (#641)
  Added `as` property to DOM props (#603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davesnx davesnx davesnx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cornedor @davesnx @peterpme