Force the client_secret to be a string. #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine. I should be able to pull this down, run the tests and get it merged tomorrow. |
|
This seems to be the same issue referenced here. Is that correct? Can this be merged? |
realdoug
added a commit
that referenced
this pull request
Apr 7, 2014
Force the client_secret to be a string.
|
Yep, done and done. |
|
Thank you sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Salesforce issues numeric client_secrets it is possible to pass this into the provider as a
Bignuminstead of a string.In my case, I am storing the client_secret in a YAML file, which interpreted it as
Bignum.