Skip to content

CoffeeScript React component generator is fixed #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

CoffeeScript React component generator is fixed #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
945f095
Rails React Component CoffeeScript version generator is fixed to outp…
ViXP Aug 11, 2017
2b7cff0
Merge branch 'master' of https://github.com/reactjs/react-rails
ViXP Oct 1, 2017
441e082
Coffee generator fixed for Webpack syntax
ViXP Oct 1, 2017
cbf3cd0
Coffee generator template fixed for Webpack syntax
ViXP Oct 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/generators/react/component_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,18 @@ def component_name

def file_header
if webpacker?
%|var React = require("react")\n|
if options[:coffee]
%|import React from 'react'\nimport PropTypes from 'prop-types'\n|
else
%|var React = require("react")\n|
end
else
''
end
end

def file_footer
if webpacker?
if webpacker? && !options[:coffee]
%|module.exports = #{component_name}|
else
''
Expand Down
4 changes: 3 additions & 1 deletion lib/generators/templates/component.js.jsx.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
class @<%= component_name %> extends React.Component
<%= file_header %>
export default class @<%= component_name %> extends React.Component
<% if attributes.size > 0 -%>
@propTypes =
<% attributes.each do |attribute| -%>
Expand All @@ -16,3 +17,4 @@ class @<%= component_name %> extends React.Component
<% else -%>
`<div />`
<% end -%>
<%= file_footer %>