Skip to content

feat: use @babel/generate to serialise AST nodes w/o loc info in `pri… #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2021
Merged

feat: use @babel/generate to serialise AST nodes w/o loc info in `pri… #482

merged 2 commits into from
Feb 6, 2021

Conversation

beauroberts
Copy link

…ntValue` (#481)

@beauroberts beauroberts mentioned this pull request Jan 21, 2021
Closed
@beauroberts beauroberts force-pushed the print-value-babel-generate branch from e4a479d to 6f9bee2 Compare January 28, 2021 12:05
@beauroberts beauroberts force-pushed the print-value-babel-generate branch from 6f9bee2 to 86d81a5 Compare January 28, 2021 14:11
@danez
Copy link
Collaborator

danez commented Feb 6, 2021

Sorry for the long delay.
I really do not like the estree-to-babel thing. but I get that it is necessary. I plan to directly use the babel ast internally at some point, because then we can also remove ast-type, but I'm getting off-topic.
I will merge this now, I guess there is no better way right now.

@danez danez merged commit 6f220dc into reactjs:master Feb 6, 2021
danez pushed a commit that referenced this pull request May 8, 2021
@danez
feat: use @babel/generate to serialise AST nodes w/o loc in `printVal…
c2f6750 
…ue` (#482)

Resolves #481
# Conflicts:
#	yarn.lock
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@beauroberts @danez