fix(traverse): only visit paths, not nodes #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traversing nodes detaches the resulting paths from the root File node, so they can end up crashing getFlowType which needs to grab the source code from the File.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traversing with
visitusing a node as the root creates a newNodePath, which detaches the resulting paths from the rootFilenode. I've seen this lead togetFlowTypecrashing later when it tries to grab the source code from the no-longer-reachableFilenode[1]. Traversing from aNodePathkeeps everything correctly linked and has no downsides AFAICT, so here I changedtraverseShallow(which wrapsvisit) to only accept paths.[1] I don't have the exact repro case to hand, unfortunately, but this was in the course of working on facebook/react-native-website#1628.