Skip to content

fail if timeout is reached #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2017
Merged

fail if timeout is reached #36

merged 1 commit into from
Apr 4, 2017

Conversation

marcpiechura
Copy link
Contributor

close #35

@marcpiechura
Copy link
Contributor Author

This could also happen on the JVM but I'm not sure what ArrayBlockingQueue does if you pass in a negative timeout into poll .

@marcpiechura marcpiechura mentioned this pull request Apr 2, 2017
Merged
@marcpiechura
Copy link
Contributor Author

marcpiechura commented Apr 4, 2017 •
edited
Loading

Ping @reactive-streams/dotnet-contributors @ktoso @akarnokd

@marcpiechura marcpiechura merged commit 47d4612 into master Apr 4, 2017
@marcpiechura marcpiechura deleted the check_for_negative_timeout branch April 4, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@akarnokd akarnokd akarnokd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ArgumentOutOfRangeException with a TimeSpan value

3 participants

@marcpiechura @akarnokd @Petabridge-CI