Fix FileInputField to call onFilesChanged even when no file is selected (#664)
#665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedrich-schindler
requested review from
adamkudrna,
atmelmicro,
Copilot,
lukasbriza and
mbohal
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug where the FileInputField component's onFilesChanged callback was not being called when users dismiss the file selection dialog or when no files are selected, ensuring proper state propagation in all scenarios.
- Added
onFilesChangedcallback invocation for empty file selections - Added
onFilesChangedcallback invocation when multiple files are selected but the input doesn't accept multiple files - Added test coverage for the scenario where no file is selected
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/FileInputField/FileInputField.jsx | Added missing onFilesChanged callback calls in empty file scenarios |
| src/components/FileInputField/tests/FileInputField.spec.tsx | Added test case to verify callback is invoked when no file is selected |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/components/FileInputField/__tests__/FileInputField.spec.tsx
Outdated
Show resolved
Hide resolved
…lected (#664) This is situation when user opens file selection dialog, but dismisses it by clicking on Close/Cancel button or pressing Escape key. Before this fix, state of the input was reset, but not propagated.
bedrich-schindler
force-pushed
the
fix/664
branch
from
eae9963 to
aeafa00
Compare
mbohal
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is situation when user opens file selection dialog, but dismisses it by clicking on Close/Cancel button or pressing Escape key.
Before this fix, state of the input was reset, but not propagated.
Closes #664