Skip to content

Conversation

hackable
Copy link
Contributor

Fixes the window not defined error

@8BallBomBom
Copy link
Member

Sorry this hasn't had the attention it needed.
Due to various reasons I've not had the time to push anything forward.
But plan to of-course.

As for the window undefined issue.
I'm not really sure if this is actually the best solution 🤔
Are you using expo?

@8BallBomBom 8BallBomBom added the confirmed The issue has been confirmed label Sep 21, 2024
@hackable
Copy link
Contributor Author

Yes, I am using Expo. This solution was implemented to address cross-platform compatibility issues, specifically to make it work across web in the Expo environment. While it may not be the ideal solution, it does seem to resolve the immediate compatibility problems we were facing. I'm open to discussing alternative approaches if you have any suggestions for improvement.

@8BallBomBom
Copy link
Member

Based on this.
How exactly are you building for the web?

@hackable
Copy link
Contributor Author

Its a cross platform audio calls app using webrtc

@8BallBomBom
Copy link
Member

Alrighty.
Is the output mode set as the default value?

@hackable
Copy link
Contributor Author

    "web": {
      "bundler": "metro",
      "output": "static",
      "favicon": "./assets/images/favicon.png"
    }

@8BallBomBom
Copy link
Member

Will push this through and then figure something out once a better solution is found.

@8BallBomBom 8BallBomBom merged commit 7a13fbe into react-native-webrtc:main Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

confirmed The issue has been confirmed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants