Lowered the iOS deployment target from 12.1 to 9.0 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making this PR! |
Waiting for this PR!:) |
|
when will this be merged? |
|
+1 |
|
What happened to this project? This issue has consum lots of time of many developers.. And after all these days. It still there? |
naveendevs
approved these changes
Sep 15, 2019
|
Let's get this in |
Thanks a lot, orta |
|
@orta can you please also publish a patch version w/ this? |
|
Any idea when this will be published in a release? |
|
I don't have NPM access, I'd check out who does and ask them 👍 |
|
Published in v1.0.3 |
|
The left out file libRNCPushNotificationIOS.a is stil empty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iOS deployment target was set to 12.1. Since this is higher than the react native default (9.0), the package was left out of release builds and, as a result, making them fail.
Fixes #17