Setup Hermes V1 testing #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipolleschi
requested changes
Nov 7, 2025
j-piasecki
force-pushed
the
@jpiasecki/test-hermes-v1
branch
from
9764245 to
d89a744
Compare
cipolleschi
requested changes
Nov 13, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for working on this. I left a couple of questions
cipolleschi
approved these changes
Nov 17, 2025
patches/hermes-v1.patch
Outdated
| "typescript": "^5.8.3" | ||
| }, | ||
| + "resolutions": { | ||
| + "hermes-compiler": "250829098.0.2" |
Contributor
There was a problem hiding this comment.
latest-v1 is now 250829098.0.3
Do you know if there is a way to use a specific tag instead of a version?
Otherwise, we would have to bump this every time we release a new version of Hermes.
Contributor
Author
There was a problem hiding this comment.
It's possible to use a tag instead of a specific version in package.json, but it needs to use the same version for the Android config.
I've added a script that will update the patch with the latest version before applying it. Is that ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets up automated testing of Hermes V1. The workflow will set up a new RN app from the template, enable Hermes V1, build the app, and run a simple E2E test using it.
E2E is based on the setup used in the React Native repository:
maestro-ios.jsmaestro-android.jsstart.ymlIf I understand the repository setup correctly, to pick up the results of the actions and show them on the website, the action needs to upload GitHub artifacts in a specific format, which I believe the new workflow does. Please correct me if I'm wrong.