Skip to content

Conversation

@retyui
Copy link
Contributor

@retyui retyui commented Oct 18, 2021

Summary

  • Add tests for useImageDimensions(...) hook
  • Test coverage 100% (implementation clear and simple)

Test Plan

yarn test

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android
Web

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've created a snack to demonstrate the changes: LINK HERE

@retyui retyui force-pushed the add-use-image-dimensions-test branch from f20fd5f to 2403712 Compare October 18, 2021 12:58
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding tests to all the hooks! ❤️

@LinusU LinusU added the skip-release Preserve the current version when merged label Oct 18, 2021
@LinusU LinusU merged commit 0f4eac4 into react-native-community:master Oct 18, 2021
@retyui retyui deleted the add-use-image-dimensions-test branch October 18, 2021 15:00
@pvinis
Copy link
Member

pvinis commented Oct 18, 2021

🚀 PR was released in v2.7.0 🚀

@pvinis pvinis added the released This issue/pull request has been released. label Oct 18, 2021
@github-actions github-actions bot mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released This issue/pull request has been released. skip-release Preserve the current version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants