Skip to content

[useImageDimensions] types refactored #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020
Merged

[useImageDimensions] types refactored #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/useImageDimensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@ export interface URISource {
uri: string
}

export type Source = ImageRequireSource | URISource
export type ImageDimensionsSource = ImageRequireSource | URISource

export interface ImageDimensions {
dimensions?: {width: number; height: number; aspectRatio: number}
width: number
height: number
aspectRatio: number
}

export interface ImageDimensionsResult {
dimensions?: ImageDimensions
error?: Error
loading: boolean
}
Expand All @@ -17,8 +23,10 @@ export interface ImageDimensions {
* @param source either a remote URL or a local file resource.
* @returns original image dimensions (width, height and aspect ratio).
*/
export function useImageDimensions(source: Source): ImageDimensions {
const [result, setResult] = useState<ImageDimensions>({loading: true})
export function useImageDimensions(
source: ImageDimensionsSource,
): ImageDimensionsResult {
const [result, setResult] = useState<ImageDimensionsResult>({loading: true})

useEffect(() => {
try {
Expand Down