feat(0.79): generate codegen before pod install
#2600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipolleschi
requested changes
Feb 18, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Left a couple of comments to make the code more maintainable!
But thank you for implementing this.
| newArchEnabled?: boolean; | ||
| iosFolderPath?: string; | ||
| platform: string; | ||
| root: string; |
Contributor
There was a problem hiding this comment.
This should be the location of the xcodeproj file. f that's the case, we are good to go.
Member
There was a problem hiding this comment.
@szymonrybczak let's call this cariable sourceDir instead of root then and pass proper value
Collaborator
Author
There was a problem hiding this comment.
I don't think so, root is where package.json should be - based on this code:
thymikee
reviewed
Feb 18, 2025
cipolleschi
approved these changes
Feb 18, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
thanks for applying the suggestions!
thymikee
reviewed
Mar 7, 2025
thymikee
reviewed
Mar 7, 2025
thymikee
approved these changes
Mar 7, 2025
szymonrybczak
deleted the
feat/0.79/run-codegen-before-running-pod-install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starting from React Native 0.79
pod installwon't invoke codegen generation logic so we have to do inside CLI.Test Plan
yarn iosin your project should generate codegen underios/buildand install Cocoapods properly.Checklist
react-nativecheckout (instructions).