Skip to content

fix: execa phantom dependency in cli-tools #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix: execa phantom dependency in cli-tools #2292

merged 1 commit into from
Feb 19, 2024

Conversation

@jbroma
Copy link
Contributor

@jbroma jbroma commented Feb 9, 2024

Summary:

execa is not declared as a dependency inside of cli-tools. This causes CLI to fail in setups with pnpm

Test Plan:

not needed

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the bugfix label Feb 9, 2024
@jbroma jbroma changed the title fix: execa phantom dependency in cli-tools fix: execa phantom dependency in cli-tools Feb 9, 2024
szymonrybczak
szymonrybczak approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@thymikee thymikee merged commit 5f4e0b9 into react-native-community:main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szymonrybczak szymonrybczak szymonrybczak approved these changes

@adamTrz adamTrz Awaiting requested review from adamTrz

@thymikee thymikee Awaiting requested review from thymikee thymikee is a code owner

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbroma @szymonrybczak @thymikee