Skip to content

feat: Enable RNCAsyncStorage. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2019
Merged

feat: Enable RNCAsyncStorage. #37

merged 1 commit into from
Mar 14, 2019

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Mar 13, 2019

Summary:

It doesn't seem like RNCAsyncStorage is enabled.

Test Plan:

All the current tests should pass.

@tido64 tido64 mentioned this pull request Mar 13, 2019
Merged
krizzu
krizzu approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this had to slip through when we're changing names.

Thanks 🎉

@krizzu krizzu merged commit aae04db into react-native-async-storage:master Mar 14, 2019
@tido64 tido64 deleted the tido64/enable-rncasyncstorage branch March 14, 2019 07:42
@krizzu
Copy link
Member

krizzu commented Mar 14, 2019

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @krizzu