JNI support with CI workflow #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrospic
force-pushed
the
jni-ci
branch
16 times, most recently
from
8867316 to
fdee0d7
Compare
Collaborator
Author
|
bors try |
nzpr
reviewed
Aug 13, 2022
| @@ -0,0 +1,241 @@ | |||
| .PHONY: clean-precomp precomp | |||
Collaborator
There was a problem hiding this comment.
Would it make sense to have a patch for original Makefile here instead of rewriting the whole file? Same for configure.ac
Collaborator
Author
There was a problem hiding this comment.
This is an initial version with the copy of the whole files. Changes should be extracted to a script or diff file.
nzpr
approved these changes
Aug 14, 2022
nzpr
approved these changes
Aug 14, 2022
Collaborator
Author
|
bors merge |
Contributor
|
Build succeeded: |
Contributor
tryTimed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds JNI support to compilation of native code for https://github.com/bitcoin-core/secp256k1.
JNI files are taken from PR which removed support on the source repo.
bitcoin-core/secp256k1#682
Also files are updated from the PR on https://github.com/bitcoin-s/bitcoin-s repo which also uses original source.
bitcoin-s/secp256k1-zkp@17ab106 (PR bitcoin-s/secp256k1-zkp#1)
Also fix for macOS for JDK path is taken from @nzpr's build.
nzpr/secp256k1@41fa378
GitHub CI workflow
GitHub workflow CI files are added with support for bors. Running examples can be seen on the fork repo.
https://github.com/tgrospic/secp256k1-native/actions/runs/2851923440
TODO
Makefile and configure are for now copied as a whole files, but later only changes should be extracted to a script of diff file to update originals.
What's missing is support for multiple architecture e.g. ARM and CI action to create releases.