RDBC-670 Streaming #238

yh-0 · 2025-05-15T13:05:38Z

https://issues.hibernatingrhinos.com/issue/RDBC-670

Rebased changes from #168
Fixed issue with duplicated constants files (ravendb/constants.py and ravendb/primitives/constants.py).
Fixed minor issues with class members names and imports.
Made sure tests related to streaming pass.

poissoncorp · 2025-05-15T13:28:15Z

Please run black code formatter over the changes 🙏 it complains about it

ravendb/documents/commands/stream.py

ravendb/documents/operations/executor.py

ravendb/documents/session/document_session.py

ravendb/documents/session/operations/stream.py

poissoncorp · 2025-05-19T09:26:14Z

ravendb/tests/jvm_migrated_tests/client_tests/streaming_tests/test_query_streaming.py

+class Users_ByName(AbstractIndexCreationTask):
+    def __init__(self):
+        super(Users_ByName, self).__init__()
+        self.map = "from u in docs.Users select new { u.name, lastName = u.lastName.Boost(10) }"


shouldn't be "last_name"?

poissoncorp · 2025-05-19T09:28:03Z

ravendb/tests/jvm_migrated_tests/client_tests/streaming_tests/test_query_streaming.py

+
+        with self.store.open_session() as session:
+            query = session.query_index_type(Users_ByName, User)
+            stream, stats = session.advanced.stream_with_statistics(query)


usually we take stats callback as a second argument in "statistics" method - here

ravendb-python-client/ravendb/documents/session/query.py

Line 2114 in e66141b

def statistics(self, stats_callback: Callable[[QueryStatistics], None]) -> DocumentQuery[_T]:

should we do the same here?

poissoncorp · 2025-05-19T09:31:39Z

let's address those comments, and fix your added tests. you can unittest.skip the one with 3!=5 for now, but the rest should be passing, so we're green again

poissoncorp · 2025-05-19T13:31:49Z

ravendb/tests/jvm_migrated_tests/client_tests/streaming_tests/test_query_streaming.py

        with self.store.open_session() as session:
+
+            def __stats_callback(statistics: StreamQueryStatistics):
+                self.assertEqual("Users/ByName", statistics.index_name)


also, check if the program runs this code

e.g. set flag callback_ran to True at the end of the callback and check at the end of the test if the callback_ran is True, not False