-
Notifications
You must be signed in to change notification settings - Fork 959
Add example for picotool reset #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Daniel Schaefer <[email protected]>
| PICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACE=1 | ||
| PICO_STDIO_USB_RESET_INTERFACE_SUPPORT_MS_OS_20_DESCRIPTOR=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These defines are already set to 1 by default, so I'm not sure how this example differs from any of the other examples which use pico_enable_stdio_usb (eg hello_usb, hello_anything, hello_universal)? All of those examples already have support for picotool reset by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's useful to know how to add support for the reset interface if you have your own usb cdc setup? usb/device/dev_multi_cdc tries to do that but I seem to recall it doesn't quite work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just had a quick hack and got it working with dev_multi_cdc, but it'll need a few SDK changes too to allow using the reset interface without the stdio_usb default descriptors - will try more in a week or so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of those examples already have support for picotool reset by default
Oh, I didn't realize that. I tried a long time with the usb examples and also those from tinyusb but the defines never worked on those. So once I finally tried them on the hello example it did work.
Then instead of my code changes, it might be useful to keep the readme changes and explicitly document that the hello example does indeed support the reset protocol.
I've just had a quick hack and got it working with dev_multi_cdc, but it'll need a few SDK changes too to allow using the reset interface without the stdio_usb default descriptors - will try more in a week or so
Cool, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@will-v-pi any luck on getting dev_multi_cdc working with picotool reset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see #694 (it requires SDK changes as well)
No description provided.