i36: Updates package to work with socket.io v4 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2022 02:33
- Replaces checked in mspack_pack.php with rybakit/msgpack composer package - Adds UID to packed message - Removes "#emitter" suffix on key fixes rase-#36
|
Thanks I used this library and your modifications as inspiration! |
|
is this working with latest socket.io? (now it should be v4.6.1) |
|
@rayyzhong I haven't tried on v4.6.1 yet, want to give it a go and report back? I've pushed my changes to the master branch of my fork here: https://github.com/robgonnella/socket.io-php-emitter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package
fixes #36