Improve groupby test utils to include the original location of failure #20718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
added
libcudf
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
commented
Nov 24, 2025
Comment on lines
+49
to
+51
| #define CUDF_TEST_SINGLE_AGG(...) cudf::test::test_single_agg(__FILE__, __LINE__, __VA_ARGS__) | ||
| #define CUDF_TEST_SUM_AGG(...) cudf::test::test_sum_agg(__FILE__, __LINE__, __VA_ARGS__) | ||
| #define CUDF_TEST_SINGLE_SCAN(...) cudf::test::test_single_scan(__FILE__, __LINE__, __VA_ARGS__) |
Contributor
Author
There was a problem hiding this comment.
The main changes are only in this file. Changes in other places are just update to use this.
Signed-off-by: Nghia Truong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, many groupby tests call to
test_single_agg()and other utility functions ingroupby_test_util.*(test_sum_agg()andtest_single_scan()) to execute the test. When a failure happens, GTest only issue a trace location to somewhere intest_single_agg()while there is not any information about the actual failed test. That makes debugging a bit tricky.This PR implements some utility macros to replace the groupby test utility functions, adding more ways to support tracing back to the original failed test:
CUDF_TEST_SINGLE_AGGCUDF_TEST_SUM_AGGCUDF_TEST_SINGLE_SCANWith this, GTest will report an additional line containing the location of the failed test. For example: