Skip to content

Conversation

@PointKernel
Copy link
Member

@PointKernel PointKernel commented Nov 21, 2025

Description

This PR promotes join_kind from the detail namespace to the public API, as it will be used by the upcoming filter_join_indices API. No functional code changes are involved.

Needed by #20385

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 21, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 21, 2025
@PointKernel PointKernel added feature request New feature or request non-breaking Non-breaking change libcudf Affects libcudf (C++/CUDA) code. and removed libcudf Affects libcudf (C++/CUDA) code. labels Nov 21, 2025
@PointKernel
Copy link
Member Author

/ok to test 252f730

@PointKernel PointKernel mentioned this pull request Nov 21, 2025
3 tasks
@PointKernel PointKernel marked this pull request as ready for review November 24, 2025 01:55
@PointKernel PointKernel requested a review from a team as a code owner November 24, 2025 01:55
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. In the new features, will we be moving towards a single API that exposes the join type as an argument? Will we want to do the same with other existing join algorithms? Let’s discuss design options and particularly any gaps in the matrix of join algorithms and supported join types, if we are heading in that direction. Possibly a good brown bag discussion but I’d like to have an issue discussing plans for the future state, for posterity.

@PointKernel
Copy link
Member Author

will we be moving towards a single API that exposes the join type as an argument?

Probably not. The only reason to expose this is to allow a unified filter_join_indices together with hash_join::inner/left/full_join, so we can replicate the behavior of mixed_inner/left/full_join. There are currently no plans to modify the existing join algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants