-
Notifications
You must be signed in to change notification settings - Fork 985
Promote join_kind from detail namespace to public #20703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test 252f730 |
bdice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. In the new features, will we be moving towards a single API that exposes the join type as an argument? Will we want to do the same with other existing join algorithms? Let’s discuss design options and particularly any gaps in the matrix of join algorithms and supported join types, if we are heading in that direction. Possibly a good brown bag discussion but I’d like to have an issue discussing plans for the future state, for posterity.
Probably not. The only reason to expose this is to allow a unified |
Description
This PR promotes
join_kindfrom the detail namespace to the public API, as it will be used by the upcomingfilter_join_indicesAPI. No functional code changes are involved.Needed by #20385
Checklist