Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Nov 20, 2025

Description

Removes the deprecated function cudf::get_current_device_resource.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner November 20, 2025 22:06
@bdice bdice requested review from PointKernel and shrshi November 20, 2025 22:06
@bdice bdice self-assigned this Nov 20, 2025
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 20, 2025
@bdice bdice added improvement Improvement / enhancement to an existing function breaking Breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Nov 20, 2025
@bdice
Copy link
Contributor Author

bdice commented Nov 21, 2025

/merge

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 21, 2025
@vyasr vyasr added the DO NOT MERGE Hold off on merging; see PR for details label Nov 21, 2025
@vyasr
Copy link
Contributor

vyasr commented Nov 21, 2025

@bdice this change needs a fix in the JNI

@bdice
Copy link
Contributor Author

bdice commented Nov 23, 2025

JNI fix is here: NVIDIA/spark-rapids-jni#4007

mythrocks pushed a commit to NVIDIA/spark-rapids-jni that referenced this pull request Nov 24, 2025
`cudf::get_current_device_resource()` is deprecated and will be removed
in rapidsai/cudf#20688. The replacement is
`cudf::get_current_device_resource_ref()`.

Similarly, `rmm::mr::get_current_device_resource()` will be removed soon
in favor of `rmm::mr::get_current_device_resource_ref()`.

This PR migrates spark-rapids-jni for both of these changes.

Signed-off-by: Bradley Dice <[email protected]>
@bdice
Copy link
Contributor Author

bdice commented Nov 24, 2025

JNI fix was merged. Merging this after CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants