Clean up mixed semi join by removing unused parameters and redundant table-swapping logic #19655
+28
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
libcudf
bdice
approved these changes
Aug 11, 2025
|
This cleanup was identified during the mixed join migration #19660. I initially thought it would be easier to review as a relatively independent change, but it turned out to have overlapping modifications with the mixed join code, making it difficult to get tests passing without significant changes there. I’ll close this PR and address all related issues together in #19660 instead. Thanks for the quick review @bdice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the mixed semi join implementation by removing unused parameters and eliminating the table-swapping logic, as it is always false in mixed semi joins.
Checklist