Use SPDX for all copyright headers #960
Conversation
There was a problem hiding this comment.
The following files didn't have the long copyright removed due to some typos:
python/pybind11/cache/cache_py.h
python/pybind11/profiler/profiler_py.h
Dual Licensed + Author:
python/cucim/src/cucim/core/operations/morphology/cuda/pba_kernels_2d.h -> MIT, 2019 School of Computing, National University of Singapore
There was a problem hiding this comment.
Thanks @KyleFromNVIDIA and @robertmaynard. I just have some question on invdividual licenses under specific folders where code was adapted from upstream projects (CuPy and scikit-image). Previously we just had top-level mention of these licenses here:
https://github.com/rapidsai/cucim/blob/main/LICENSE-3rdparty.md
but now do we need to reproduce that information on a per-file basis?
There was a problem hiding this comment.
Files under this _vendored folders are slightly modified version of CuPy's cupyx.scipy.ndimage code under MIT license
https://github.com/cupy/cupy?tab=MIT-1-ov-file#readme
Do we need to include that in the header for the files in this folder?
There was a problem hiding this comment.
With the exception of the _vendored folder which contains modified versions of CuPy code, most files under python/cucim/src/cucim/skimage are adapated from pre-existing scikit-image code under a few different permissive licenses (BSD 2-clause, BSD 3-clause and MIT). See details here:
https://github.com/scikit-image/scikit-image?tab=License-1-ov-file#readme
One exception to this are the files matching python/cucim/src/cucim/skimage/measure/_regionprops_gpu*.* which are original to cuCIM and have no counterpart upstream.
|
Every file that was taken from somewhere else should have per-file copyright and license notices. Please give me a list of files with their licenses here. |
Let me create some type of script and upload as a document with the result as there are > 100 files. |
|
The following files are adapted from CuPy and have license Copyright (c) 2015 Preferred Infrastructure, Inc. The following files are: Copyright: 2003-2009 Massachusetts Institute of Technology in addition to Copyright: 2009-2022 the scikit-image team The following files is: Copyright: 2009-2015 Board of Regents of the University of in addition to Copyright: 2009-2022 the scikit-image team The following files are: Copyright: 2003-2009 Massachusetts Institute of Technology in addition to Copyright: 2009-2022 the scikit-image team The following file is: Copyright: 2020 Broad Institute in addition to Copyright: 2009-2022 the scikit-image team The following file is: Copyright: 1994 Karel Zuiderveld in addition to Copyright: 2009-2022 the scikit-image team The following file is: function function is_installed: in addition to Copyright: 2009-2022 the scikit-image team And finally the following files are based on corresponding scikit-image files with license: Copyright: 2009-2022 the scikit-image team |
python/cucim/src/cucim/skimage/filters/cuda/histogram_median.cu
Outdated
Show resolved
Hide resolved
|
Thanks for making all those updates @KyleFromNVIDIA! I left comments on two individual files where there was an oversight in my prior list. |
There was a problem hiding this comment.
Thank you so much @KyleFromNVIDIA for updating these!
I have a few suggestions that might have been missed.
Otherwise, everything looks good to me!
cpp/plugins/cucim.kit.cuslide/src/cuslide/jpeg2k/libopenjpeg.cpp
Outdated
Show resolved
Hide resolved
cpp/plugins/cucim.kit.cuslide/src/cuslide/jpeg2k/color_conversion.cpp
Outdated
Show resolved
Hide resolved
cpp/plugins/cucim.kit.cuslide/src/cuslide/jpeg/libjpeg_turbo.cpp
Outdated
Show resolved
Hide resolved
|
@gigony Please see my updates. I added the copyright notices and modified the |
Thanks @KyleFromNVIDIA ! The change looks great! |
|
/merge |
5 participants
Issue: https://github.com/rapidsai/build-infra/issues/297