Disabling the edit and create buttons #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rancher no longer supplies the appropriate fields to render the dynamic forms. - `resourceFields` is now null - `resourceDefinitions` doesn't supply the `update/create fields` Fixes rancher/dashboard#14139
codyrancher
commented
Apr 17, 2025
|
|
||
| ## License | ||
|
|
||
| Copyright (c) 2014-2024 [Rancher Labs, Inc.](http://rancher.com) |
There was a problem hiding this comment.
I'm assuming we want to update this but I can revert if needed.
codyrancher
commented
Apr 17, 2025
| <button type="button" class="btn btn-primary btn-sm" onclick="htmlapi.up()" {{#unless operations.up}}disabled="disabled"{{/unless}}><span class="glyphicon glyphicon-arrow-up"></span> Up</button> | ||
| <button type="button" class="btn btn-primary btn-sm" onclick="htmlapi.reload()"><span class="glyphicon glyphicon-refresh"></span> Reload</button> | ||
| {{#if operations.post}} | ||
| {{!-- {{#if operations.post}} |
There was a problem hiding this comment.
I decided to skip comment out instead of deleting to make this easier to find in the future and this repo isn't anything like the code we typically work on.
codyrancher
added a commit
to codyrancher/rancher
that referenced
this pull request
Apr 17, 2025
…d in rancher Update PR rancher/api-ui#47
|
@codyrancher Where did we get to with this PR? |
@nwmac IIRC I think this was only a partial fix which is why I never asked for a review. If it's something we still want I could review this for 2.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rancher no longer supplies the appropriate fields to render the dynamic forms.
resourceFieldsis now nullresourceDefinitionsdoesn't supply theupdate/create fieldsFixes rancher/dashboard#14139