Reworked JS helpers with APi #17 #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably needs some client-side code review. Are we OK with shipping the code as jQuery plugin? |
|
Well done @kirs ! 👍 |
lib/active_form/view_helpers.rb
Outdated
There was a problem hiding this comment.
Won't inserting a script element break turbolinks?
There was a problem hiding this comment.
My first idea was to create a hidden div with content, but as my colleague told script is better than div because it's not rendering in DOM.
We can also use the template tag from HTML5 instead of script.
kirs
force-pushed
the
experimental
branch
3 times, most recently
from
e34172a to
cb5fa96
Compare
|
Done. If we're ok with implementation, let's merge it. @m-Peter @kaspth @guilleiguaran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dfyx noticed that there is no way to add new fields in JS without using buttons.
Here is my implementation (may not work yet on edge cases) with an API:
Example of form code can be found here: https://github.com/kirs/activeform/blob/e9375a9d6fac5e0e9ff893dc30e22e2e8bb112dd/test/dummy/app/views/assignments/_form.html.erb