Use first binding when there is no application binding #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an error happens inside the framework before loading application, the ActionDispatch::ExceptionWrapper shows traces for the framework only. It could be outside of "Rails.root", and so we have to fallback to the first one.
|
(@rails-bot has picked a reviewer for you, use r? to override) |
|
Can we write a test for that as well? |
|
I have added a test 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error happens inside the framework before loading our application, the
ActionDispatchshows traces for the framework. It could be outside ofRails.root, so we have to fallback to the first one. This pull request changes theSessionclass to use the first binding when there is no application binding.Thank you.