First-class Terser support #818
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports https://github.com/ahorek/terser-ruby/blob/master/lib/terser/compressor.rb (MIT licensed) to this gem, to add first-class support for Terser in the same manner that Uglifier, YUI, etc. are supported.
Issue raised in Terser gem to notify the maintainers of this port: ahorek/terser-ruby#65
Motivation
Recently, I replaced the Uglifier with Terser in my Gemfile and Rails config, expecting it to be a drop in replacement:
When I deployed to staging, the process errored during bootstrapping because constant
Terser
could not be found. In a nutshell, the reason why Uglifier works and Terser does not is becauseSprockets::UglifierCompressor
exists in Sprockets lib and does not require theuglifier
gem to already be loaded, while the Terser equivalent is loaded by a Railtie in theterser
gem which does require loadingterser
gem first.