Should `attr_reader` and similar be part of the search index?

[Earlopain]

As it says in the title.

They are displayed in docs and are similar enough to methods that they probably should?

[p8]

I agree, but I think this should probably be fixed upstream in RDoc:
https://github.com/ruby/rdoc/blob/master/lib/rdoc/generator/json_index.rb#L230-L246

[Earlopain]

Huh, didn't realize RDoc does the same thing. SDoc has its own logic for that, separate from RDoc (I think). Are you saying RDoc should go first regardless?

[p8]

Ah my mistake, I forgot we basically generate the index in SDoc:
https://github.com/rails/sdoc/blob/main/lib/sdoc/search_index.rb
In general, if things can be fixed RDoc, that would have precedence.
We have some monkey patches, but that's not ideal:
https://github.com/rails/sdoc/blob/main/lib/sdoc/rdoc_monkey_patches.rb

[p8]

Hmm, we do get the method_list from RDoc:

sdoc/lib/sdoc/search_index.rb

Line 16 in 242686d

rdoc_objects = rdoc_modules + rdoc_modules.flat_map(&:constants) + rdoc_modules.flat_map(&:method_list)

Maybe this should be fixed somewhere in RDoc:
https://github.com/ruby/rdoc/blob/7fb0e509ec3f16f636b65d82b286594f87b27d46/lib/rdoc/code_object/context.rb

[Earlopain]

I don't think they are strictly considered methods: https://github.com/ruby/rdoc/blob/7fb0e509ec3f16f636b65d82b286594f87b27d46/lib/rdoc/code_object/context.rb#L30

They also have their own type/class I think. I can try to make a PR for this and see how it plays out.