Infrastructure to invoke a backtrace cleaner for failed jobs backtraces #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosa Could I get this looked at and any feedback necessary to move it forward? Hal |
|
@hms yes! Sorry for the delay, I didn't have time last week to look at it but I had it in my plans. I'll try to review next week. |
rosa
reviewed
Aug 25, 2024
|
@rosa Are there still outstanding issues that I haven't addressed? I would love for this to get pushed so I can get back onto the mainline releases. |
…obs screen * Defaults to the standard Rails backtrace_cleaner * Can be overridden with a user supplied backtrace_cleaner via an initializer
I inadvertantly early initialized the Rails.backtrace_cleaner as part of setting MissionControl wide defaults. This commit uses a proc as the default so the database cleaner will be initialized in the Application environment (vs. the Gems's) Fixed a typo where I referenced the Gems state instead of the Applicaations state to access the database cleaner
* (Hopefully) addressed @rosa's feedback on project style, code quality, and implementation requirements * Updated the design to support both a global MissionControl::Jobs wide backtrace cleaner and Application/Server specific backtrace cleaners * With this commit, the implementation relies less on jobs_helper.rb and more on a new before_action in the jobs_controller. * Added more UI testing for compleness
* Moves defaults handling from MissionControl::Jobs::Application to MissionControl::Jobs::Server to minimize impact of this new feature on the existing implementation and tests. This fixes the unit test failure that I missed in the previous commit. * Uses @server rather than looking it up via params in the JobsController. This allows reverting all changes to the JobsController.
hms
force-pushed
the
backtrace_cleaner
branch
from
f68b461 to
927ae8c
Compare
|
@hms sorry for the delay! All great now 👍 👍 Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a button to allow invoking a backtrace_cleaner on the backtrace of a failed job.