Deprecation error using Ruby 2.7

[ecentell-CPF]

While using Ruby 2.7 and the most recent commit f6dc08c the following error is logged:

c:/Ruby27-x64/lib/ruby/gems/2.7.0/bundler/gems/execjs-f6dc08c58ab4/lib/execjs/external_runtime.rb:176: warning: Using the last argument as keyword parameters is deprecated

[meirroth]

Having the same issue using 2.7.0

C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:176: warning: Using the last argument as keyword parameters is deprecated

Running Jekyll 4.1.1
Windows 10

[ecentell-CPF]

Hello, are any devs monitoring this project? Please advise!

[ecentell-CPF]

Including the last two PR merge users @guilleiguaran @rafaelfranca as I'm not sure who may or may not be receiving these notifications.

[ecentell-CPF]

2 months...anyone? @josh @jeremy @judofyr

[judofyr]

In 2.7.2 there are no longer any deprecation warnings shown by default: https://www.ruby-lang.org/en/news/2020/10/02/ruby-2-7-2-released/.

We should probably make sure that ExecJS is ready for Ruby 3.0 as well.

[stevecheckoway]

Execjs no longer works on Windows using Ruby 3.0. I'm not sure why File.popen is okay, but the File.open on that line raises a type error.

     TypeError:
       no implicit conversion of Hash into Integer
     # ./vendor/bundle/ruby/3.0.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:176:in `initialize'
     # ./vendor/bundle/ruby/3.0.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:176:in `open'
     # ./vendor/bundle/ruby/3.0.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:176:in `exec_runtime'
     # ./vendor/bundle/ruby/3.0.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:39:in `exec'
     # ./vendor/bundle/ruby/3.0.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:14:in `initialize'
     # ./vendor/bundle/ruby/3.0.0/gems/execjs-2.7.0/lib/execjs/runtime.rb:57:in `new'
     # ./vendor/bundle/ruby/3.0.0/gems/execjs-2.7.0/lib/execjs/runtime.rb:57:in `compile'
     # ./vendor/bundle/ruby/3.0.0/gems/execjs-2.7.0/lib/execjs/module.rb:27:in `compile'

Looks like #95 would fix the issue.

[ecentell-CPF]

Can any dev check in and confirm?

[ecentell-CPF]

Trying to get some traction on getting this commit tested/merged. Any 5+ contributors able to help in this instance?
@josh @sstephenson @rafaelfranca @stereobooster @judofyr @tricknotes

[judofyr]

Unfortunately I don't have commit access to this repo so I can't help :(

[boovius]

Running Jekyll. Seeing this wonderful error:

.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:41:in `exec'
/Users/joshuabook/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:41:in `unlink': Interrupted system call @ apply2files - /var/folders/bh/wm_t_rvj2fjgqd46sjc47jyc0000gn/T/execjs20210409-40132-ibaq5gjs (Errno::EINTR)

Would love any tips on this.

[stevecheckoway]

Running Jekyll. Seeing this wonderful error:

.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:41:in `exec'
/Users/joshuabook/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/execjs-2.7.0/lib/execjs/external_runtime.rb:41:in `unlink': Interrupted system call @ apply2files - /var/folders/bh/wm_t_rvj2fjgqd46sjc47jyc0000gn/T/execjs20210409-40132-ibaq5gjs (Errno::EINTR)

Would love any tips on this.

I don’t think that that is related to this issue. That error message indicates that the unlink system call was interrupted by a signal. I’ve never seen unlink be interrupted by a signal before. I didn’t even think it could be! You should probably file a separate issue, but be warned, this project seems unmaintained.

[ecentell-CPF]

Will an updated version get put to RubyGems soon?