fix: Unsafe shell command constructed from library input #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this problem, we should avoid passing interpolated strings to
system
that are constructed from potentially untrusted input. Instead, we should use the form ofsystem
that takes each argument separately, which bypasses the shell and avoids interpretation of special characters. In this case, we can replacesystem "command -v #{tool} > /dev/null"
withsystem("command", "-v", tool, out: File::NULL, err: File::NULL)
. This approach ensures that thetool
argument is passed directly to the command without shell interpretation, and the output is redirected to/dev/null
in a safe, cross-platform way. We only need to change the implementation oftool_exists?
inlib/install/helpers.rb
.