fix OpenStack calls #968
fix OpenStack calls #968
Conversation
| # Open a single file stack | ||
| function Base.open(f::Function, st::AbstractRasterStack{K,T,<:Any,<:FileStack{X}}; kw...) where {X,K,T} | ||
| ost = OpenStack{X,K,T}(parent(st)) | ||
| function Base.open(f::Function, st::AbstractRasterStack{K}; kw...) where K |
There was a problem hiding this comment.
Lol! I didnt realize this was how it happens.
Can't we just define
Base.open(st::AbstractRasterStack{K}; kw...) = OpenStack(parent(st))
Base.close(st::AbstractRasterStack{K}; kw...) = somehow_flatten_and_invoke_on_openstack(close, st) # maybe replace with filearrayand that's lazy=:open?
It looks like the multifile implementation is recursive but we could figure that out.
There was a problem hiding this comment.
Yeah, but that will be part of doing that properly everywhere?
(And not exactly, you need to wrap as a RasterStack)
There was a problem hiding this comment.
These are the easy stacks where it's one dataset, often it's not
There was a problem hiding this comment.
And fwiw lazy=:open is confusing syntax, it has to be something else
There was a problem hiding this comment.
Something else is fine, I don't even mind single-arg Base.open(ras) or Rasters.open(filename)
There was a problem hiding this comment.
The reason not to only allow open(rast) is it needs a double open. It should work too but as an option for a lazy raster
Raster(fn; open=true) would open to get metadata and just stay open.
|
Probably test in stack.jl ? |
I just added it to gribdatasets.jl to not have to write another file. I've checked it errors on main. |
open(stack)seems to be broken on main.Needs test but not sure which files to use?