-
Couldn't load subscription status.
- Fork 39
Do not use Base.get_extension
#1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
Why a type and not a singleton? |
|
Yeah a singleton is probably marginally better, if you want to change them over @tiemvanderdeure |
Use singleton instances instead of types for extension loaded
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
+ Coverage 82.89% 83.69% +0.80%
==========================================
Files 58 68 +10
Lines 5425 5484 +59
==========================================
+ Hits 4497 4590 +93
+ Misses 928 894 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! And CI runs
Drop the use of
Base.get_extensionin favour of an is_loaded function that is overloaded inside of each extensionCloses #1025