Skip to content

Conversation

@lazarusA
Copy link
Collaborator

@lazarusA lazarusA commented May 27, 2025

updates to DocumenterVitepress 0.2, plus some stars.

#1002 broke a lot of doctests.

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.03%. Comparing base (765f9ae) to head (2a9227c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/groupby.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   84.05%   84.03%   -0.02%     
==========================================
  Files          52       52              
  Lines        5135     5136       +1     
==========================================
  Hits         4316     4316              
- Misses        819      820       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tiemvanderdeure
Copy link
Collaborator

Can doctest(; fix = true) help here?

@lazarusA
Copy link
Collaborator Author

Can doctest(; fix = true) help here?

don't know what that is? or where to use it 😄 .

@tiemvanderdeure
Copy link
Collaborator

don't know what that is? or where to use it 😄 .

it updates the docstrings with their actual output (according to the Documenter docs)

@tiemvanderdeure
Copy link
Collaborator

Let's see if #1016 fixes those broken doctests

@lazarusA
Copy link
Collaborator Author

I don't think it will help 😄

ok, now is definitely not on my hands,

ERROR: LoadError: UndefKeywordError: keyword argument `separatorwidth` not assigned
Stacktrace:
  [1] show_after(io::IOContext{IOBuffer}, mime::MIME{Symbol("text/plain")}, A::DimensionalData.DimGroupByArray{DimMatrix{Float64, Tuple{X{Sampled{Float64, 

https://github.com/rafaqz/DimensionalData.jl/actions/runs/15275527574/job/42960851648?pr=1015#step:6:99

@rafaqz any pointers on where and why this is failing.

@tiemvanderdeure
Copy link
Collaborator

tiemvanderdeure commented May 27, 2025

Just found that bug also and fixed it in the other PR. You can just copy over the commit

Edit: here's the link to the commit. 16450b9

@lazarusA
Copy link
Collaborator Author

lazarusA commented May 27, 2025

Just found that bug also and fixed it in the other PR. You can just copy over the commit

Edit: here's the link to the commit. 16450b9

na, let's merge that one first, then we do this one.

EDIT: @tiemvanderdeure well, I merged your branch here, let's see 😄 .

@tiemvanderdeure
Copy link
Collaborator

Hm I already got a test failure there. Seems doctest added Dates. everywhere even though there is using Dates in the docstring

@lazarusA
Copy link
Collaborator Author

Hm I already got a test failure there. Seems doctest added Dates. everywhere even though there is using Dates in the docstring

no worries, I can take care of that.

@lazarusA
Copy link
Collaborator Author

nice! we did it 😄 . Building locally works without any issues, let's wait now just for CI now.

@tiemvanderdeure tiemvanderdeure mentioned this pull request May 27, 2025
@lazarusA
Copy link
Collaborator Author

preview:
https://rafaqz.github.io/DimensionalData.jl/previews/PR1015/

good to go @rafaqz .

@rafaqz rafaqz merged commit 7ee6bf8 into main May 27, 2025
7 of 10 checks passed
@rafaqz rafaqz deleted the la/DVPress_dot2 branch May 27, 2025 16:38
@rafaqz
Copy link
Owner

rafaqz commented May 27, 2025

Thanks, looks great

felixcremer pushed a commit to felixcremer/DimensionalData.jl that referenced this pull request Jul 4, 2025
* construct dimensions before concatenating stack layers

* ups for DVPress 0.2

* wanrnonly due to broken doctests

* doctest false

* fix print of dimgroupbyarray

* update docstrings using `doctest(DD; fix = true)`

* revert commit from different PR (oops)

* construct dimensions before concatenating stack layers

* fix print of dimgroupbyarray

* update docstrings using `doctest(DD; fix = true)`

* revert commit from different PR (oops)

* no false

* drop `Dates.` in docstrings

* link to integrations

---------

Co-authored-by: tiemvanderdeure <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants