-
Notifications
You must be signed in to change notification settings - Fork 184
Update/migrate vue cli to vite #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saidy-moregeo
wants to merge
14
commits into
vuejs3-migration
Choose a base branch
from
update/migrate-vue-cli-to-vite
base: vuejs3-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea4562c to
71771d3
Compare
…er into update/migrate-vue-cli-to-vite
…rth/stac-browser into update/migrate-vue-cli-to-vite
Collaborator
|
@saidy-moregeo Are the issues described at the beginning still relevant? |
m-mohr
reviewed
Nov 22, 2025
Comment on lines
-9
to
+15
| <meta name="og:url" id="og-url" content="<%= htmlWebpackPlugin.options.url %>"> | ||
| <meta property="og:title" id="og-title" content="<%= htmlWebpackPlugin.options.title %>"/> | ||
| <meta name="og:url" id="og-url" content=""> | ||
| <meta property="og:title" id="og-title" content="STAC Browser"/> | ||
| <meta name="og:description" id="og-description" content=""> | ||
| <meta name="og:locale" id="og-locale" content="en"> | ||
| <meta name="og:site_name" content="<%= htmlWebpackPlugin.options.title %>"> | ||
| <meta name="og:site_name" content="STAC Browser"> | ||
| <!-- <script defer="defer" src="/config.js"></script> --> | ||
| <title><%= htmlWebpackPlugin.options.title %></title> | ||
| <title>STAC Browser</title> |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please migrate to use variables again using vite-plugin-html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite Migration: Dynamic Import Issues
Critical Issue: MapMixin.js Basemap Loading (BROKEN)
File:
src/components/maps/MapMixin.js:176-178Vite cannot resolve dynamic imports from node_modules with template literal variables:
Error:
Module name 'ol/source/XYZ.js' does not resolve to a valid URLImpact: Basemaps fail to load
Locale File Imports (NOT Working with import.meta.glob)
Files:
DatePickerMixin.js,i18n.js,MetadataGroups.vue,Validation.vueUsing
import.meta.glob()for locale files fails at runtime with errors like:Root Cause: Locale files re-export from external packages (e.g.,
date-fns/locale,@musement/iso-duration). When Vite processes glob imports, it cannot resolve these external bindings from node_modules during static analysis.Example from
DatePickerMixin.js: