Fix/date picker format #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er into fix/routing
…er into fix/routing
…er into fix/routing
…er into fix/date-picker-format
saidy-moregeo
added
codebase
m-mohr
requested changes
Nov 20, 2025
src/locales/id/datepicker.js
Outdated
Comment on lines
29
to
30
| weekStartsOn: 1, // Monday is the first day of the week. | ||
| firstWeekContainsDate: 7, // The week that contains Jan 7th is the first week of the year. |
…er into fix/date-picker-format
…-browser into fix/date-picker-format
m-mohr
reviewed
Nov 21, 2025
m-mohr
reviewed
Nov 21, 2025
m-mohr
reviewed
Nov 21, 2025
…-browser into fix/date-picker-format
m-mohr
reviewed
Nov 21, 2025
m-mohr
reviewed
Nov 21, 2025
m-mohr
reviewed
Nov 21, 2025
src/locales/pt/datepicker.js
Outdated
|
|
||
| export default {dateFormat, timeFormat, dateTimeFormat, locale}; | ||
| // minimal override to support a custom 'min' width with two-letter weekday tokens | ||
| const minDayValues = ['Do', '2ª', '3ª', '4ª', '5ª', '6ª', 'Sá']; |
Collaborator
There was a problem hiding this comment.
@psacra Are there the commonly used values for calendars / date pickers? The numbers look odd to me :-)
m-mohr
approved these changes
Nov 21, 2025
Collaborator
|
Merging, but reviews of our translators would still be highly appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
French locale for Canada and Switzerland was using fr locale without any customization, but on date-fns they have separate locale for both Canada and Switzerland which has different configurations for example in Canada the week starts on Sunday do I live it has it is or mimic the previous approach even though we don't use french-canada 🍁 or french-switzerland 🇨🇭 locale.
For Italy locale for days on the previous is ['do', 'lu', 'ma', 'me', 'gi', 've', 'sa'] and on the new one is ["dom", "lun", "mar", "mer", "gio", "ven", "sab"] do you think we should change it or stick with this new select as it doesn't break UI as in the case of Indonesia date-fns locale.